[Commits] commit/EinsteinInitialData: 62 new changesets

Bitbucket commits-noreply at bitbucket.org
Thu Sep 17 17:57:49 CDT 2020


62 new commits in EinsteinInitialData:

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/623e1d6cd1bf/
Changeset:   623e1d6cd1bf
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:45+00:00
Summary:     ReadInterpolate: interpolate 3d data onto a new Cactus grid

Affected #:  8 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/c60206643541/
Changeset:   c60206643541
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:45+00:00
Summary:     ReadInterpolate: initial functional commit

ReadInterpolate is a FileReader like thorn that uses LocalInterpUniform to
interpolate the read in data onto the target grid. This means that the
grid structures can be completely arbirary. However only interpolators
provided by LocalInterp or AEILocalInterp can be used. This means
essentially only Lagrange and Hermite polynomials but no ENO.

Right now the reader will only allow for the selection of which grid
variables to read via a global regular expresion a la hdf5_slicer. It is
limited to CCTK_REAL grid functions as well.

For a usage example see the test admhydro.

Affected #:  28 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/49daa231cbbc/
Changeset:   49daa231cbbc
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add mesh refinement to test source data

Affected #:  17 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/47d81b4b4efb/
Changeset:   47d81b4b4efb
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix off by one error in ghost zone computation

I need to include a point whenever it is inside of the outermost ghost
point, not at least at the first real point.

Beyond that some guards against roundoff were introduced, the logic to
fill points made more robust and a check if all points were populated
was introduced.

On the down side we now run in level mode which means that without
further optimazations that HDF5 files are read once for each target
refinement level. This is needed to look like an ID thorn so
prim2coninitial sees our data.

Affected #:  24 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/a09580f62195/
Changeset:   a09580f62195
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: simplify selecting which datasets to read

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/56e1753f8a59/
Changeset:   56e1753f8a59
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add error checking for non-matching Regex, make more
tolerant against whitespace

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/cd594683f59c/
Changeset:   cd594683f59c
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add explicit options to restrict reflevels loaded

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/a35999bc6118/
Changeset:   a35999bc6118
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix parsing of tag=value part of dataset names

this also fixes the problem that tl!=0 timelevels were read in.

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/e15bf68f7b60/
Changeset:   e15bf68f7b60
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add option to shift origin of read in datasets

Affected #:  8 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/09384d7e0f6b/
Changeset:   09384d7e0f6b
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: split ParseObject function into sub-functions

* remove some superflous logic
* add some extra error checks

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/771da3829339/
Changeset:   771da3829339
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: check return value of RegexMatch for invalid regex

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/8d08e6b4f65f/
Changeset:   8d08e6b4f65f
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: define trim() function removing whitespace from

beginning and end of strings

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/1059ab1f90da/
Changeset:   1059ab1f90da
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: modify to work with multipatch targets

this actually meant to remove some code :-)

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/30ba4d3fe993/
Changeset:   30ba4d3fe993
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix error in test.ccl, fix carpet grid output file

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/2295e76ba5a4/
Changeset:   2295e76ba5a4
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: some typos in param.ccl descriptions

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/e5d3aa8dcb32/
Changeset:   e5d3aa8dcb32
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add option to convert between rot90 and full grid setup

this currently only works for scalars. For vectors/tensors one would
also have to apply the symmetry to the components rather than just the
locations.

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/84cb25ff6cba/
Changeset:   84cb25ff6cba
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: special code for outer boundary and Parameters group

some clarification of status and error messages.

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/1893aa548b02/
Changeset:   1893aa548b02
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: improve error messages

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/d01dff2165a5/
Changeset:   d01dff2165a5
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: consider only grid functions when reading datasets

this is useful when the input is a checkpoint and we simply want to read
in all grid functions (since we do not support anything else anyway).

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/9aa0117778f4/
Changeset:   9aa0117778f4
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: skip integer grid functions

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/d7ef7ec3190b/
Changeset:   d7ef7ec3190b
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix assignment vs. comparison in assert()s

this effectively rendered the assert's into no-ops and rendered a later
check on the read-in data size non-functional.

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/df4ebd71d9a0/
Changeset:   df4ebd71d9a0
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: remove incorrect assert()s on HDF5 types

instead of trying to verify that the types are what we expect, let HDF5
attempt a conversion and die if the conversion fails.

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/6c28dcf5e767/
Changeset:   6c28dcf5e767
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: make param.ccl comments clearer

the orginal ones were taken from IOUtil and not quite clear enough

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/3dbe9a65614e/
Changeset:   3dbe9a65614e
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: make trim() a static function, use it correctly

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/1af68c57cd72/
Changeset:   1af68c57cd72
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: check regular expressions in ParamCheck

this adds a sanity check to check that each given regular expression
matches as least one Cactus variable name

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/031fec0398c8/
Changeset:   031fec0398c8
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: let use know if we skip a dataset if verbosity >= 2

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/a2174a1b2026/
Changeset:   a2174a1b2026
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: avoid compiler warning about uninitialized variables

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/764ab44522bb/
Changeset:   764ab44522bb
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: output list of variables read when done

this is to reassure users that we actually read in the variables that
they wanted to read

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/0dcb61cd2039/
Changeset:   0dcb61cd2039
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: keep track of read in points for each variable

before we used shared one tracker for all variables but this fails if
the input files have different reflevel structure

Affected #:  4 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/6c276f320edd/
Changeset:   6c276f320edd
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: correct inverted logic in paramcheck

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/6f51d6f62f98/
Changeset:   6f51d6f62f98
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add option to enforce symmetry on read in data

this is done by scheduling the bc "none" for them. Off by default since
it changes values and requires an extra SYNC call (in the C code)

Affected #:  4 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/f76bd4b993d1/
Changeset:   f76bd4b993d1
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add option to read in multiple timelevels

Affected #:  4 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/f6c59a70dcf5/
Changeset:   f6c59a70dcf5
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: support runnint with init_each_timelevel

this should make it easier to read three levels of data from checkpoints

this requires that a new parameter
ReadInterpolate::max_number_of_read_variables is set properly, otherwise
the code aborts outputting the correct number

Affected #:  6 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/9397f951ac3f/
Changeset:   9397f951ac3f
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix bug in selecting which timelevel to read

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/659112cc24ff/
Changeset:   659112cc24ff
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: clarify debug output

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/b2641bd82c18/
Changeset:   b2641bd82c18
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix forgotten if() condition on timelevel

this made it read in all timelevels all the time and in the end using
tl=0

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/634b92bce894/
Changeset:   634b92bce894
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: support interpolators using different number of ghosts

the number of ghost zones the interpolator requires affects which points
can be interpolated into while the number of ghost in the evolution
scheme is of no relevance to ReadInterpolate

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/d9a2eb12a933/
Changeset:   d9a2eb12a933
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: only use matching rl data for tl>0

this is because for tl>0 the rl are not aligned in time

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/ee69b3cd43c7/
Changeset:   ee69b3cd43c7
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: exit a little bit later to always allocate storage

this is just a workaround, in theory this would still happen if *none*
of the grid patches in the file was suitable at all.

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/f3ddefe8e03e/
Changeset:   f3ddefe8e03e
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadIntepolate: add code for time interpolation

untested, will not work since I have yet to schedule the actual time
interpolation routine sometime after all TL have been read but before
SYNCs happen

Affected #:  5 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/e9eb27be91bb/
Changeset:   e9eb27be91bb
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: work around origin in CarpetIOHDF5

older versions of CarpetIOHDF5 (I won't put the git hash here) don't set
"origin" correctly for cell centered data, however using iorigin,
ioffset and ioffsetdenom I can recompute what should be there.

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/ee74c3a74ac0/
Changeset:   ee74c3a74ac0
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: add parameter to control ioffset fixup code

there is information missing in the HDF5 files to undo the incorrect
offset and no foolproof heuristic exists

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/79f1b7b52dce/
Changeset:   79f1b7b52dce
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: actually schedule time interpolation

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/8a76e135039f/
Changeset:   8a76e135039f
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: cache dataset attributes between calls

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/5ec0eca8dbd4/
Changeset:   5ec0eca8dbd4
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: report leaked HDF5 objects when flushing cache

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/293efd41b2d2/
Changeset:   293efd41b2d2
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: use schedule to control temp storage

this also fixes a bug where interpthispoint and interp_coords were not
released

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/e9a29826cfc8/
Changeset:   e9a29826cfc8
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: complain if more objects are open than before we ran

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/d0cfdbfba103/
Changeset:   d0cfdbfba103
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: fix syntax in interface.ccl

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/01cd541f7818/
Changeset:   01cd541f7818
Branch:      None
User:        Roland Haas
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: do not assume lsh == ash

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/7deaf0d8ad4c/
Changeset:   7deaf0d8ad4c
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: update data file path in test

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/d49d9095bf36/
Changeset:   d49d9095bf36
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:46+00:00
Summary:     ReadInterpolate: remove broken time interpolation code

Affected #:  4 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/adf9810a12c0/
Changeset:   adf9810a12c0
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: correct TOV test file writer

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/fd67818e5f36/
Changeset:   fd67818e5f36
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: add code for correctness test

Affected #:  13 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/46d54186c957/
Changeset:   46d54186c957
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove non-functional undo90 parameter

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/7a3fedff0314/
Changeset:   7a3fedff0314
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove commented out loops over reflevels

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/73709ef392d9/
Changeset:   73709ef392d9
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove redundant {} block

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/6b9620a00cc8/
Changeset:   6b9620a00cc8
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: use CCTK_VWARN etc macros

Affected #:  3 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/b7c73b257b11/
Changeset:   b7c73b257b11
Branch:      None
User:        rhaas80
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: add documnetation

fix some typos in param.ccl description

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/5668d67d8619/
Changeset:   5668d67d8619
Branch:      None
User:        Roland Haas
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove redundant read_only_timelevel_0 parameter

its functionality is already provided by Carpet's parmeters
Carpet::init_each_timelevel (equivalent to read_only_timelevel_0 being
false) and Carpet::init_fill_timelevels (equivalent to
read_only_timelevel_0 being true)

Affected #:  2 files

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/f1953062f906/
Changeset:   f1953062f906
Branch:      None
User:        Roland Haas
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove use of read_only_timelevel_0 from synthetic test

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/a9c6097831b2/
Changeset:   a9c6097831b2
Branch:      None
User:        Roland Haas
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: remove read_only_timelevel_0 from docs

Affected #:  1 file

https://bitbucket.org/einsteintoolkit/einsteininitialdata/commits/56a96c986db4/
Changeset:   56a96c986db4
Branch:      master
User:        Roland Haas
Date:        2020-09-17 22:43:47+00:00
Summary:     ReadInterpolate: spellcheck and USize spelling in docs

Affected #:  1 file

Repository URL: https://bitbucket.org/einsteintoolkit/einsteininitialdata/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.


More information about the Commits mailing list