[ET Trac] [Einstein Toolkit] #388: handling of OMP continuation lines in f_file_processor.pl

[Einstein Toolkit]

#388: handling of OMP continuation lines in f_file_processor.pl
---------------------+------------------------------------------------------
  Reporter:  rhaas   |       Owner:  rhaas 
      Type:  defect  |      Status:  review
  Priority:  minor   |   Milestone:        
 Component:  Cactus  |     Version:        
Resolution:          |    Keywords:        
---------------------+------------------------------------------------------

Comment (by rhaas):

 Replying to [comment:4 hinder]:
 > I can test it on Kraken. Is there a testsuite that should be run, or
 some other parameter file?
 Greatly appreciated.
 There is no real testsuite since it only modifies a Cactus internal file
 used to produce the Fortran source that the compiler sees (the .f90 files
 in build/ThornName). However any of the GRHydro tests would likely do. In
 particular GRHydro/test/test/GRHydro_test_tov_ppm_ML.par with the
 following changes to GRHydrdo_Con2Prim.F90 (to actually trigger any non-
 trivial changes). I had tested that it compiles (and runs) with
 LoopControl for Fortran (which generates long OMP lines).

 {{{
 Index: src/GRHydro_Con2Prim.F90
 ===================================================================
 --- src/GRHydro_Con2Prim.F90    (revision 226)
 +++ src/GRHydro_Con2Prim.F90    (working copy)
 @@ -1154,7 +1154,7 @@
  !!$    do j = GRHydro_stencil + 1, ny - GRHydro_stencil
  !!$      do i = GRHydro_stencil + 1, nx - GRHydro_stencil
    !$OMP PARALLEL DO PRIVATE(i,j,itracer,&
 -  !$OMP uxx, uxy, uxz, uyy, uyz, uzz, det)
 +  !$OMP uxx,                        uxy, uxz,
 uyy, uyz, uzz, det)
    do k = 1, nz
      do j = 1, ny
        do i = 1, nx
 }}}

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/388#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit