[ET Trac] [Einstein Toolkit] #490: McLachlan test case failing due to ADMBase variable differences

[Einstein Toolkit]

#490: McLachlan test case failing due to ADMBase variable differences
------------------------------------+---------------------------------------
  Reporter:  hinder                 |       Owner:  eschnett 
      Type:  defect                 |      Status:  review   
  Priority:  critical               |   Milestone:           
 Component:  EinsteinToolkit thorn  |     Version:           
Resolution:                         |    Keywords:  McLachlan
------------------------------------+---------------------------------------

Comment (by rhaas):

 The proposed patch (again :-) ) removes boundary and SetTmunu calls from
 after AtmosphereReset in GRHydro. Since AtmosphereReset depends (in part)
 on values in spacemask which were set only in the interior (in
 GRHydro_UpdateMask.F90 line 84, they depend on RHS values in GRHydroRHS),
 it can only reset points to atmosphere in the interior as well (though it
 is quite possible that it actually loops over everything).

 While I do agree with everyone else that these calls are annoying, violate
 all kinds of conventions, abuse MoL and can possibly impact performance
 (since they involve communication), I believe they are still necessary
 (unless one determines that no "Hydro_Atmosphere/atmosphere" bits are set
 in any of the regions affected by SYNC and boundaries on any of the
 processors.

 Can any of the GRHydro users/developers confirm this (or confirm that
 these schedule items do not need to be present after all)?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/490#comment:6>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit