[ET Trac] [Einstein Toolkit] #476: GRHydro test suite failures (the ones using McLachlan)

[Einstein Toolkit]

#476: GRHydro test suite failures (the ones using McLachlan)
------------------------------------+---------------------------------------
  Reporter:  bmundim                |       Owner:        
      Type:  defect                 |      Status:  closed
  Priority:  major                  |   Milestone:        
 Component:  EinsteinToolkit thorn  |     Version:        
Resolution:  fixed                  |    Keywords:        
------------------------------------+---------------------------------------
Changes (by hinder):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 I fixed this a while ago.  Closing the ticket.

 >>>

 User: hinder
 Date: 2011/07/25 09:47 AM

 Modified:
 /trunk/test/
  GRHydro_test_tov_ppm_ML.par,
 GRHydro_test_tov_ppm_ML_disable_internal_excision.par,
 GRHydro_test_tov_ppm_no_trp_ML.par

 Log:
 Use 2 CoordBase boundary points instead of 1 in McLachlan tests

 McLachlan (ML_BSSN_O2) requires two ghost/boundary points due to the
 dissipation and upwinded advection operators. Kranc-generated thorns now
 check that the correct number of ghost and boundary points are available,
 and this check causes three GRHydro tests to fail as they use a boundary
 size of 1. It turns out that if you disable the check, the original
 GRHydro test suite still passes on Intel with Linux (Damiana) but
 segfaulted on GCC with Mac OS (my laptop). The dissipation and unwinding
 operators will be reading off the edge of the grid, so the behavior is
 undefined. Dissipation is set to 0 in this test, but a nonzero shift is
 used. This commit sets the CoordBase boundary size to 2 in the tests, and
 this requires the test data to be regenerated (the following commit).

 <<<

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/476#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit