[ET Trac] [Einstein Toolkit] #438: Allow a configuration.ccl for the flesh
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Wed Aug 17 10:59:10 CDT 2011
#438: Allow a configuration.ccl for the flesh
-----------------------+----------------------------------------------------
Reporter: eschnett | Owner: hinder
Type: defect | Status: review
Priority: minor | Milestone:
Component: Other | Version:
Resolution: | Keywords:
-----------------------+----------------------------------------------------
Comment (by hinder):
The patch should be modified to add the empty configuration.ccl file, as
it is indeed required. I have tested that an existing ET configuration
compiles after the patch is applied, and also after reconfiguring. I have
not tested with a full recompile.
I am puzzled by several aspects of the patch. The change to
make.configuration seems fine. The change to CST is skipping adding a
thorn to the Makefile if it is Cactus, which I don't fully follow - could
you explain this part?. The changes to ConfigurationParser.pl and
CreateConfigurationBindings.pl also appear unrelated to this ticket (and
should delete lines rather than commenting them out).
Maybe this could be split into separate patches.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/438#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list