[ET Trac] [Einstein Toolkit] #468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined

[Einstein Toolkit]

#468: CCTK_GFINDEX3D should check indices when CCTK_DEBUG is defined
-----------------------+----------------------------------------------------
  Reporter:  eschnett  |       Owner:  hinder
      Type:  defect    |      Status:  review
  Priority:  minor     |   Milestone:        
 Component:  Cactus    |     Version:        
Resolution:            |    Keywords:        
-----------------------+----------------------------------------------------

Comment (by hinder):

 The patch looks to be correct, and should be very useful if people know
 about using the DEBUG option.  Most people probably think, as I did, that
 it enables debugging symbols. In fact, the simfactory documentation on the
 "--debug" option states this.

 I have tested (on my laptop) that the ML_BSSN_sgw3d_rhs test still passes
 both with and without DEBUG=yes (via simfactory --debug), and that if I
 manually edit the code in McLachlan to loop outside the range with
 --debug, I get the required error.

 The patch uses cctk_lsh.  Should it use cctk_lssh instead, to be
 compatible with future padding features? I don't remember the details of
 that.

 Please apply.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/468#comment:6>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit