[ET Trac] [Einstein Toolkit] #539: Test recoverML is failing

[Einstein Toolkit]

#539: Test recoverML is failing
------------------------------------+---------------------------------------
  Reporter:  hinder                 |       Owner:           
      Type:  defect                 |      Status:  new      
  Priority:  major                  |   Milestone:           
 Component:  EinsteinToolkit thorn  |     Version:           
Resolution:                         |    Keywords:  McLachlan
------------------------------------+---------------------------------------

Comment (by barry.wardell):

 It can't have been the change to Vectors as that shouldn't have changed
 the behavior of the code at all.

 I think it is quite likely that it is the commit after the mentioned
 McLachlan one:

 {{{
 commit 16c7cc3c66cab59041cfb2203953eaa21cd7812d
 Author: Barry Wardell <barry.wardell at gmail.com>
 Date:   Thu Aug 18 00:12:46 2011 +0200

     Regenerate code with Vectorisation enabled.

     Note that this also applies the changes from commit
     3ba8a55ae2578cb6dc06f0ec8b81f86b3a2654ac to ML_BSSN_MP,
 ML_BSSN_MP_Helper,
     ML_BSSN_MP_O8, ML_BSSN_MP_O8_Helper, ML_BSSN_O2, ML_BSSN_O2_Helper,
     ML_BSSN_O8, ML_BSSN_O8_Helper, ML_BSSN_UPW and ML_BSSN_UPW_Helper,
 which were
     accidentally missed in that commit.
 }}}

 In particular, this applied the recent schedule updates (which were
 already applied to other McLachlan thorns) to ML_BSSN_O2. So I think the
 root cause of the change was:

 {{{

 commit 3ba8a55ae2578cb6dc06f0ec8b81f86b3a2654ac
 Author: Erik Schnetter <schnetter at cct.lsu.edu>
 Date:   Tue Aug 2 20:37:19 2011 -0400

     Correct schedule, in particular for checkpoint/recovery

     Do not mark ADMBase variables for non-checkpointing if they have
     multiple timelevels. (Variables with multiple timelevels must always
     be checkpointed, because the past timelevels cannot be regenerated
     after recovery.)

     Finally remove all perl post-processing of the auto-generated code;
     instead, use proper Kranc mechanisms.

     Schedule the ADM constraints and ADM quantities after MoL_PostStep,
     since this is where the ADMBase variables are set.

     Schedule enforcing the BSSN constraints in the new schedule group
     MoL_PostStepModify, since they should not be enforced after recovery.
     (This would lead to inconsistencies at floating-point round-off
     level.)

     Regenerate all thorns.
 }}}

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/539#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit