[ET Trac] [Einstein Toolkit] #123: Run a syntax checker in a pre-commit hook

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Mar 8 07:19:20 CST 2011


#123: Run a syntax checker in a pre-commit hook
--------------------------+-------------------------------------------------
  Reporter:  eschnett     |       Owner:  mthomas
      Type:  enhancement  |      Status:  review 
  Priority:  major        |   Milestone:         
 Component:  SimFactory   |     Version:         
Resolution:               |    Keywords:         
--------------------------+-------------------------------------------------
Changes (by hinder):

  * status:  new => review


Comment:

 The attached patch runs pylint and pychecker on every invocation of the
 "sim" shell script.  On my laptop it adds approximately one second to the
 execution time for "sim help".  It looks for the checker binary under
 several names.  For example, fink installs pychecker as pychecker-py26.

 Currently, pychecker reports very few warnings, but pylint reports a large
 number.  It would be good to understand and fix these, and if they are
 false positives, to add exceptions for them, before committing this patch.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/123#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list