[ET Trac] [Einstein Toolkit] #123: Run a syntax checker in a pre-commit hook

[Einstein Toolkit]

#123: Run a syntax checker in a pre-commit hook
--------------------------+-------------------------------------------------
  Reporter:  eschnett     |       Owner:  mthomas
      Type:  enhancement  |      Status:  review 
  Priority:  major        |   Milestone:         
 Component:  SimFactory   |     Version:         
Resolution:               |    Keywords:         
--------------------------+-------------------------------------------------

Comment (by hinder):

 They output warnings to the screen and return a nonzero exit code if there
 were any.  I decided not to check the exit code in the current patch
 because that would stop people from running even for non-problems, and
 because there are currently a large number of reports from pylint, and a
 small number from pychecker.

 Once we have fixed all the current reports, or marked them as OK in the
 checkers, we can check the exit code and abort in the case of an error,
 but I think it's premature to do it until that is the case.

 I can add pylint-2.4 to the list of pylints.  I don't know a good generic
 way of locating it.

 Michael: could you give the patch a try and see if you understand any of
 the warnings which are being produced?  Some of them looked trivial to
 fix, such as missing docstrings, and we could even suppress that
 particular one for now.  It would be good to get these down to zero.

 Of course, this should not take priority over the "blocker" and "critical"
 tickets.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/123#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit