[ET Trac] [Einstein Toolkit] #664: track should have a "reviewed" state for tickets whose attached patch has been reviewed

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Nov 8 21:29:36 CST 2011


#664: track should have a "reviewed" state for tickets whose attached patch has
been reviewed
-----------------------------------+----------------------------------------
  Reporter:  rhaas                 |       Owner:     
      Type:  enhancement           |      Status:  new
  Priority:  minor                 |   Milestone:     
 Component:  EinsteinToolkit trac  |     Version:     
Resolution:                        |    Keywords:     
-----------------------------------+----------------------------------------

Comment (by knarf):

 I don't think we should introduce yet another state, which would
 complicate the workflow even more. What are the possible options when a
 ticket in 'review' state is reviewed:

 a) The patch is accepted, and the reviewer decides to commit. He can then
 close the bug.
 b) The patch is accepted, and the reviewer decides to let the submitter of
 the bug commit the patch. This should happen in a relatively short
 timeframe (the submitter should be notified). If this is the case, there
 is no problem. If this is not the case and it takes a long time it would
 probably be good to keep it in 'review' so that people are reminded often
 that there is this outstanding, but solved issue. Maybe the reviewer just
 changes her mind and commits after some silence from the submitter.
 c) The patch is not accepted. In this case the bug should be reassigned to
 someone, most likely the submitter. The 'review' state would be deleted.
 d) The problem was "not valid" or a "duplicate" or some other special case
 which can already be taken care of.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/664#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list