[ET Trac] [Einstein Toolkit] #605: Simfactory does not find the right 'path' for symlinked cactus directories

Einstein Toolkit trac-noreply at einsteintoolkit.org
Fri Oct 7 10:49:45 CDT 2011


#605: Simfactory does not find the right 'path' for symlinked cactus directories
-------------------------+--------------------------------------------------
  Reporter:  knarf       |       Owner:  eschnett           
      Type:  defect      |      Status:  review             
  Priority:  minor       |   Milestone:  ET_2011_10         
 Component:  SimFactory  |     Version:  development version
Resolution:              |    Keywords:                     
-------------------------+--------------------------------------------------

Comment (by eschnett):

 Simfactory doesn't really use "chdir". There are a few chdir commands
 surrounding calls to external programs (e.g. before calling the
 runscript), and these should probably be replaced by explicit "cd"
 commands in the executed commands.

 That is, constructs such as
 {{{
    orig = os.getcwd()
    chdir (somewhere)
    system "do-something"
    chdir (orig)
 }}}
 should be replaced by
 {{{
    system "cd somewhere && do-somethig"
 }}}
 which are shorter, and where there is no chdir involved.

 (Using chdir is usually not a good idea, because the current directory is
 a global state variable, and using chdir is thus equivalent to using a
 global variable.)

 It should thus be safe to use PWD; if not, I would consider this a low-
 priority bug in Simfactory.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/605#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list