[ET Trac] [Einstein Toolkit] #626: Recovery fails in AHFinderDirect RecoverML with out-of-bounds assertion in CarpetLib

[Einstein Toolkit]

#626: Recovery fails in AHFinderDirect RecoverML with out-of-bounds assertion in
CarpetLib
--------------------+-------------------------------------------------------
 Reporter:  rhaas   |       Owner:  eschnett  
     Type:  defect  |      Status:  new       
 Priority:  major   |   Milestone:  ET_2011_10
Component:  Carpet  |     Version:            
 Keywords:          |  
--------------------+-------------------------------------------------------
 when trying to recover in AHFinderDirect's RecoverML test (parfiles
 attached) I get:
 {{{
 cactus_et:
 /home/rhaas/ET_2011_10/arrangements/Carpet/CarpetLib/src/th.hh:79: double
 th::get_time(int, int, int) const: Assertion `tl>=0 and tl<timelevels'
 failed.
 }}}

 After some debuggin I traced this down to the metric which in
 CarpetIOHDF5/src/Input.cc:762 is reported (by gf->timelevels (ml, rl)) to
 have three timelevels. However the timelevels member of gf->t (a th) gives
 the number of timelevels as two
 {{{
  gf->t.timelevels
 $28 = 2
 }}}

 Since timelevels is new in Carpet/Hg my suspicion would be that it is not
 properly updated when gf->set_timelevels is called (the comments in th.hh
 seem to indicated that it is assumed to be const which seems odd given
 that ggf::set_timelevels exists).

 I don't understand enough of Carpet to fix or further debug this. Marking
 its as major and release relevant in case it is actually a Carpet bug.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/626>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit