[ET Trac] [Einstein Toolkit] #570: Bad check in AEILocalInterp

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Sep 20 11:09:42 CDT 2011


#570: Bad check in AEILocalInterp
-----------------------------------+----------------------------------------
 Reporter:  sbrandt                |       Owner:     
     Type:  defect                 |      Status:  new
 Priority:  minor                  |   Milestone:     
Component:  EinsteinToolkit thorn  |     Version:     
 Keywords:                         |  
-----------------------------------+----------------------------------------
 In AEIThorns/AEILocalInterp/src/InterpLocalUniform.c
 1370 if (value_not_set)
 1371    then {
 1372     /* default operand will use each input exactly once, */
 1373     /* but this only makes since if N_input_arrays == N_output_arrays
 */
 1374     if (N_input_arrays != N_input_arrays)
 1375        then {
 1376         free(input_array_offsets);
 1377         free(operand_indices);
 1378         CCTK_VWarn(ERROR_MSG_SEVERITY_LEVEL,

 The test is always going to fail and data is not going to be freed up.
 Based on the comment, I think that the test should compare N_input_arrays
 to N_output_arrays.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/570>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list