[ET Trac] [Einstein Toolkit] #586: Syntax errors in make/make.config.rules.in

[Einstein Toolkit]

#586: Syntax errors in make/make.config.rules.in
----------------------+-----------------------------------------------------
 Reporter:  eschnett  |       Owner:     
     Type:  defect    |      Status:  new
 Priority:  critical  |   Milestone:     
Component:  Cactus    |     Version:     
 Keywords:            |  
----------------------+-----------------------------------------------------
 The file make.config.rules.in contains shell syntax errors, e.g. in this
 construct:

 define NOTIFY_PREPROCESSING
        { if test "$(VERBOSE)" == "yes"; then echo Preprocessing $<; fi }

 1. "test" doesn't know the "==" operator, it's "=" instead
 2. Commands within { } need to be terminated by a semicolon

 Also:

 3. In other places, we allow both upper and lower case settings

 And:

 4. The { } seem superfluous here; the if ... fi already brackets the
 statement
 5. The VERBOSE variable could be checked by make, not by the shell

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/586>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit