[ET Trac] [Einstein Toolkit] #586: Syntax errors in make/make.config.rules.in

[Einstein Toolkit]

#586: Syntax errors in make/make.config.rules.in
-----------------------+----------------------------------------------------
  Reporter:  eschnett  |       Owner:  knarf   
      Type:  defect    |      Status:  reopened
  Priority:  critical  |   Milestone:          
 Component:  Cactus    |     Version:          
Resolution:            |    Keywords:          
-----------------------+----------------------------------------------------

Comment (by eschnett):

 The first line sets a shell variable VERBOSE, the second line checks a
 make variable VERBOSE. These are different variables. The first line is
 therefore inconsequential. These line should instead read

 {{{
 VERBOSE=`echo $(VERBOSE) | ...
 if test "$$VERBOSE" ...
 }}}

 If you say VERBOSE=YES, then the lines "Preprocessing" are never output.

 Another way of implementing this would be

 {{{
 ifneq ($(shell echo $(VERBOSE) | tr '[:upper:]' '[:lower:]'),yes)
   define NOTIFY_PREPROCESSING
   endef
   ... other definitions
 else
   define NOTIFY_PREPROCESSING
     echo "Preprocessing $<..."
   endef
   ... other definitions
 endif
 }}}

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/586#comment:9>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit