[ET Trac] [Einstein Toolkit] #798: allow calculations in parameter assignments in parameter files

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Apr 18 18:07:50 CDT 2012


#798: allow calculations in parameter assignments in parameter files
--------------------------+-------------------------------------------------
  Reporter:  rhaas        |       Owner:        
      Type:  enhancement  |      Status:  review
  Priority:  optional     |   Milestone:        
 Component:  Cactus       |     Version:        
Resolution:               |    Keywords:        
--------------------------+-------------------------------------------------

Comment (by rhaas):

 sigh. Error checking is hard and humans have a funny idea of what a
 logical syntax for math is. Anyhow attached please find a patch that makes
 things a bit easier.

 1. somewhat useful error messages
 1. a test suite
 1. some fixes in the priorities of operators (should now be essentially as
 in C, though associativity is likely different eg for {{{**}}})
 1. properly handles multi-char operators now
 1. {{{**}}} for power
 1. handles nan/inf/-inf/-nan
 1. fixes a bug where the first state transition happened twice (is an
 issue for tokens that may not repeat)
 1. I've left fmod in for now (forgot to rewrite the macro to take a type
 as argument as well, have to do some real work now). Also what I wanted to
 say in the last post is that the behaviour of '%' is implementation
 dependent, but fmod() is not and for this reason I would prefer fmod()
 with integer arguments over '%'.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/798#comment:15>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list