[ET Trac] [Einstein Toolkit] #832: ExternalLibraries/zlib gives bad error message if "patch" is not available

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Apr 26 07:50:26 CDT 2012


#832: ExternalLibraries/zlib gives bad error message if "patch" is not available
-----------------------------------+----------------------------------------
 Reporter:  hinder                 |       Owner:     
     Type:  defect                 |      Status:  new
 Priority:  minor                  |   Milestone:     
Component:  EinsteinToolkit thorn  |     Version:     
 Keywords:                         |  
-----------------------------------+----------------------------------------
 The PATCH variable is used in the zlib configuration script but there is
 no check that it has been set.  It is also not declared in the
 configuration.ccl as being used.  Should all environment variables used in
 the script be declared?  PATCH is usually set by autoconf, unless it is
 unavailable, in which case it is not set.

 Replacing $PATCH with ${PATCH?} would be enough to give a sensible error
 message.  I don't know if there are versions of bash that would not
 understand this.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/832>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list