[ET Trac] [Einstein Toolkit] #681: LSUThorns/Vectors: Update Kranc-specific code
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Jan 16 09:56:09 CST 2012
#681: LSUThorns/Vectors: Update Kranc-specific code
------------------------------------+---------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: review
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Resolution: | Keywords:
------------------------------------+---------------------------------------
Comment (by eschnett):
#define does not have name scopes. If E is defined, we assume it comes
from Kranc, and redefine it to its proper value with vectorisation (i.e.
with ToReal). If it is not defined, then we don't define it here either.
If we #define E here unconditionally, and some code tries to use it as a
variable/type name, then this will fail. This would insert the identifier
E into all source code, even those not using Kranc.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/681#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list