[ET Trac] [Einstein Toolkit] #738: use catch/throw in LORENE ID thorns to report file-open failures

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Jan 26 07:28:35 CST 2012


#738: use catch/throw in LORENE ID thorns to report file-open failures
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:        
      Type:  defect                 |      Status:  review
  Priority:  minor                  |   Milestone:        
 Component:  EinsteinToolkit thorn  |     Version:        
Resolution:                         |    Keywords:        
------------------------------------+---------------------------------------

Comment (by eschnett):

 Using C++ exceptions should be fine. You may want to check that they are
 supported (by the compiler, and by Simfactory's options) on the relevant
 systems; some HPC systems are quite weird (e.g. Blue Gene/P does not
 support symbolic links).

 (I would have added a "#include <cctk.h>", and then called CCTK_WARN to
 abort.)

 Your patch disables a "rm -rf", probably unintentionally.

 The patch is fine, please apply.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/738#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list