[ET Trac] [Einstein Toolkit] #963: Improve McLachlan accuracy
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Sun Jul 8 13:14:01 CDT 2012
#963: Improve McLachlan accuracy
------------------------------------+---------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: review
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Resolution: | Keywords:
------------------------------------+---------------------------------------
Comment (by rhaas):
This seems to be based on 3e4bb765aaff1776ef3da6840d55b4c417875803
"Regenerate ML_ADM" which is from 2011-11-20. So my first questions would
be if we could get a patch against a more modern version of McLachlan
(ideally one including CCZ4 since it also modifies the equations quite a
bit). The second comment (this is turning into a paper review) is that in
enforceCalc the file does:
{{{
phi -> Max[phi,10^(-16)],
}}}
which seems wrong for the phi method where phi is the log of the conformal
factor and might well be negative. Finally I would find it very useful if
comments a la PRD XX YYYYY (ZZZZ) eqn EE were added for the constraint
damping terms C1-C4. Since the source is the only documentation for ML it
would be nice if all the references required to even understand where the
equations come from were contained in it,
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/963#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list