[ET Trac] [Einstein Toolkit] #945: add higher order restriction parameter to cell-centerd Carpet
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Jun 4 12:26:22 CDT 2012
#945: add higher order restriction parameter to cell-centerd Carpet
------------------------------------+---------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: reopened
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Resolution: | Keywords: CarpetLib
------------------------------------+---------------------------------------
Changes (by eschnett):
* status: closed => reopened
* resolution: fixed =>
Comment:
Actually, let's keep the ticket open, we should look at the code again and
clean it up:
- The parameter "use_cc_o3" should instead be
"use_higher_order_restriction" or similar. The actual restriction order
should then be the same as the prolongation order (up to what is
available).
- The code in dh.cc needs to be cleaned up. This concerns the way in which
the source domain for the operator is enlarged to ensure that the
restriction stencil fits. I am not convinced that the current code is
correct in all cases.
- The implementation of the actual operator could be modernised (although
this is not necessary).
- The documentation of the stencil that is given above in this ticket
should go into the source code.
There is a remark regarding synchronisation. However, there is no code to
synchronise. Is Carpet's current behaviour regarding synchronisation
already correct?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/945#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list