[ET Trac] [Einstein Toolkit] #889: GRHydro atmosphere bug

[Einstein Toolkit]

#889: GRHydro atmosphere bug
------------------------------------+---------------------------------------
  Reporter:  reisswig               |       Owner:                     
      Type:  defect                 |      Status:  new                
  Priority:  critical               |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:                     
Resolution:                         |    Keywords:  GRHydro, atmosphere
------------------------------------+---------------------------------------

Comment (by rhaas):

 Christian Reisswig and I discussed the patch and came up with a new
 version. This one extents the region of the grid it affects by one cell at
 the upper edge which means it matches the MON regions in GRHydro_PPM.F90
 lines 770ff. It now also declares both the (i,j,k) and the
 (i-xoffset,j-yoffset,k-zoffset) Riemann Problems to be potentially non-
 trivial since rhominus affects the problem at
 (i-xoffset,j-yoffset,k-zoffset) and rhoplus affects the one at (i,j,k).

 I am also noting that this loop does not take MHD into account and that
 another option would be to look at a single interface and its left/right
 values then reset only that Riemann Problem (to the average of the cell
 values left and right of the interface). That would be more of a new
 feature than an obvious bugfix though.

 Ok to apply in this form?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/889#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit