[ET Trac] [Einstein Toolkit] #814: Allow different timers on different processors in TimerReport
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Tue May 15 21:07:13 CDT 2012
#814: Allow different timers on different processors in TimerReport
------------------------------------+---------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: review
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Resolution: | Keywords: TimerReport
------------------------------------+---------------------------------------
Comment (by eschnett):
This patch is okay to apply.
If you want, you can keep the type of all_timernames; there is no need to
change from char[][] to char[]. You would write
{{{
char (*restrict const all_timernames)[TIMERNAME_LENGTH] =
malloc(total_ntimers * sizeof *all_timernames);
}}}
which would save the explicit index calculations, and would avoid the need
to cast the type for compare_string_array. However, this is not necessary
to apply the patch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/814#comment:6>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list