[ET Trac] [Einstein Toolkit] #906: GRHydro: clean-up unused variables
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Thu May 17 12:40:42 CDT 2012
#906: GRHydro: clean-up unused variables
------------------------------------+---------------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: reviewed_ok
Priority: minor | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Resolution: | Keywords: GRHydro
------------------------------------+---------------------------------------
Changes (by rhaas):
* status: review => reviewed_ok
Comment:
The patch applies and compiles and reduces the number of warnings. There
are some leftover warnings afterwards that might be cleaned up at the same
time:
{{{
COMPILING GRHydro/src/GRHydro_Con2PrimM_pt.c
GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘grhydro_con2primm_pt_’:
GRHydro/src/GRHydro_Con2PrimM_pt.c:214:32: warning: declaration of ‘gamma’
shadows a global declaration [-Wshadow]
GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘twod_newton_raphson’:
GRHydro/src/GRHydro_Con2PrimM_pt.c:513:13: warning: variable ‘vsq_old’ set
but not used [-Wunused-but-set-variable]
GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘func_vsq’:
GRHydro/src/GRHydro_Con2PrimM_pt.c:629:22: warning: variable ‘Wsq’ set but
not used [-Wunused-but-set-variable]
GRHydro/src/GRHydro_Con2PrimM_pt.c: At top level:
GRHydro/src/GRHydro_Con2PrimM_pt.c:479:13: warning: ‘validate_x’ defined
but not used [-Wunused-function]
COMPILING GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function
‘grhydro_con2primm_polytype_pt_’:
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:209:32: warning: declaration
of ‘gamma’ shadows a global declaration [-Wshadow]
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function
‘oned_newton_raphson’:
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:496:13: warning: variable ‘W’
set but not used [-Wunused-but-set-variable]
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:492:27: warning: variable
‘x_old’ set but not used [-Wunused-but-set-variable]
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function ‘gnr2’:
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:696:27: warning: variable
‘x_old’ set but not used [-Wunused-but-set-variable]
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: At top level:
GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:462:13: warning: ‘validate_x’
defined but not used [-Wunused-function]
}}}
Otherwise fine to apply.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/906#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list