[ET Trac] [Einstein Toolkit] #910: Cactus does not detect circular schedule items

[Einstein Toolkit]

#910: Cactus does not detect circular schedule items
--------------------+-------------------------------------------------------
 Reporter:  rhaas   |       Owner:     
     Type:  defect  |      Status:  new
 Priority:  minor   |   Milestone:     
Component:  Cactus  |     Version:     
 Keywords:          |  
--------------------+-------------------------------------------------------
 Right now none of the three schedule items below (which should all be
 flagged as faulty I think), triggers any warning during compile or run
 time:
 {{{
 schedule group ordertest at initial
 {
 } "test schedule sorter"

 schedule ADMBase_CartesianMinkowski in ordertest after ADMBase_LapseOne
 {
   LANG: C
 } "Set the metric and extrinsic curvature to cartesian minkowski values"

 schedule ADMBase_LapseOne in ordertest after ADMBase_CartesianMinkowski
 {
   LANG: C
 } "Set the lapse to 1 at all points"

 SCHEDULE ADMBase_SetShiftStateOn in ordertest after
 ADMBase_SetShiftStateOn
 {
   LANG: C
 } "Set the shift_state variable to 1"
 }}}

 I attach:
 * a patch against ADMBase/schedule.ccl to demonstrate the output
 * stdout when one runs Exact/Schwarzschild_EF with the faulty schedule.ccl
 * a patch against src/schedule/ScheduleSorter.c and Creator that adds
 error checks for this situation (the part inside of TEST_SCHEDULECREATOR
 is for the stand-alone test inside to compile)

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/910>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit