[ET Trac] [Einstein Toolkit] #900: GRHydro: do not use the Slopelimiter function

Einstein Toolkit trac-noreply at einsteintoolkit.org
Sun May 20 15:16:05 CDT 2012


#900: GRHydro: do not use the Slopelimiter function
------------------------------------+---------------------------------------
  Reporter:  bmundim                |       Owner:                      
      Type:  defect                 |      Status:  review              
  Priority:  minor                  |   Milestone:  ET_2012_05          
 Component:  EinsteinToolkit thorn  |     Version:                      
Resolution:                         |    Keywords:  GRHydro slopelimiter
------------------------------------+---------------------------------------

Comment (by rhaas):

 Reading the email archive: the bugfix is in SUPERBEE, the other changes
 simply remove limiters which we suspect to be wrong but don't care enough
 about to actually fix, yes?

 The patch seems to not have a final "else" clause anymore which is
 generally a bad idea (since one should never assume no one will ever add a
 case "d" to the cases "a", "b", "c" we are testing for). The removed
 slopelimiter had such a line:
 {{{
     call CCTK_WARN(0, "Type of limiter not recognized")
 }}}

 Beyond that the consensus seems to have been to apply this patch. So:
 please apply (possibly adding an "else" clause).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/900#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list