[ET Trac] [Einstein Toolkit] #695: Don't buffer output from configuration scripts

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Nov 13 22:36:15 CST 2012

#695: Don't buffer output from configuration scripts
  Reporter:  eschnett  |       Owner:             
      Type:  defect    |      Status:  reviewed_ok
  Priority:  minor     |   Milestone:             
 Component:  Cactus    |     Version:             
Resolution:            |    Keywords:             
Changes (by rhaas):

  * status:  review => reviewed_ok


 I am not sure I understand all the perl constructs used.

 In line 35 a select is used to make $lines the current filehandle. However
 according to [http://perldoc.perl.org/functions/select.html] select sets
 the default output filehandle, while $files is used for input (of the
 script's output). So it seems to make no sense to set its buffering (see
 [http://perldoc.perl.org/perlvar.html]). <Nitpicking>Is $line_number
 actually used anywhere? It is not a drop in replacement since it adds a
 bit of extra output telling the user which script runs. Not sure how
 helpful it is in a parallel build.</Nickpicking> (yes I have read the "How
 to review patches guide" hence the tags).

 Otherwise the patch looks fine.

Ticket URL: <https://trac.einsteintoolkit.org/ticket/695#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit

More information about the Trac mailing list