[ET Trac] [Einstein Toolkit] #1070: EOS_Omni::poly_gamma_ini should default to poly_gamma
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Tue Sep 11 01:31:07 CDT 2012
#1070: EOS_Omni::poly_gamma_ini should default to poly_gamma
------------------------------------+---------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: review
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Resolution: | Keywords:
------------------------------------+---------------------------------------
Comment (by rhaas):
Going one step further: should we remove poly_gamma_ini altogether as well
as (for the Gamma-law, polytropic and possibly hybrid EOS) remove the
conversion from/to cgs units that happens in each EOS call? They seem to
not do anything since it always converts back and forth and no user
visible quantity uses cgs units.
We would still need comments explaining the magic numbers (or replace them
by values from thorn Constants if they are the same).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1070#comment:8>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list