[ET Trac] [Einstein Toolkit] #590: McLachlan should allow other thorns to set the gauge

[Einstein Toolkit]

#590: McLachlan should allow other thorns to set the gauge
------------------------------------+---------------------------------------
  Reporter:  bmundim                |       Owner:  diener    
      Type:  defect                 |      Status:  assigned  
  Priority:  major                  |   Milestone:  ET_2013_05
 Component:  EinsteinToolkit thorn  |     Version:            
Resolution:                         |    Keywords:            
------------------------------------+---------------------------------------

Comment (by diener):

 The above patch attempts to split out the lapse and shift evolution from
 the main RHS routines.
 It also implements simpler and much easier routines for Harmonic and 1+log
 lapse evolution and a routine that implements the gamma2 evolution scheme
 from BSSN_MoL. The lapse_evolution_method from ADMBase are extended by the
 values ML_BSSN_Harmonic and ML_BSSN_1+Log in addition to ML_BSSN and the
 corresponding routines are scheduled conditionally on those values. The
 choice ML_BSSN results in the same slicing as before. The
 shift_evolution_method parameter is similar extended by ML_BSSN_gamma2 in
 addition to the previously available ML_BSSN. The choice ML_BSSN results
 in the same shift as before. All gauge routines are scheduled after
 ML_BSSN_RHS1 and ML_BSSN_RHS2 but before ML_BSSN_Advect. The advection
 terms for the gauges are moved out from ML_BSSN_Advect and into the gauge
 evolution routines, since the advection terms should only be added if the
 gauge is evolved. I also moved dissipation for the lapse and shift
 variables out of ML_BSSN_Dissipation and into separate
 ML_BSSN_DissipationLapse and ML_BSSN_DissipationShift routines that are
 only scheduled if McLachlan is doing the gauge evolutions. Dissipation
 routines are scheduled after the advection routine.

 As far as I can see there is not a significant performance difference.
 Performance may even be a bit better.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/590#comment:11>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit