[ET Trac] [Einstein Toolkit] #1405: TOVSolver: do not set conservatives, remove TOV_Atmosphere

[Einstein Toolkit]

#1405: TOVSolver: do not set conservatives, remove TOV_Atmosphere
-----------------------------------+----------------------------------------
 Reporter:  rhaas                  |       Owner:                     
     Type:  enhancement            |      Status:  new                
 Priority:  minor                  |   Milestone:                     
Component:  EinsteinToolkit thorn  |     Version:  development version
 Keywords:  TOVSolver              |  
-----------------------------------+----------------------------------------
 the attached two patches remove TOV_Atmosphere[] from the code and do not
 set the conservative variables. Instead TOVSolver relies on GRHydro to set
 the conservatives in InitialPrim2Con and to enforce atmosphere in
 initialatmospherereset. This also fixes any asymmetry in atmosphere
 handling between the stars.

 Most tests pass without change (since GRHydro ran anyway), the failing one
 being the test_two_av TOVSolver test which the second one regenerates.
 Differences are small but above threshold in the average case.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1405>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit