[ET Trac] [Einstein Toolkit] #1406: Commit r5034 to the flesh breaks many external libraries
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Wed Jul 24 22:28:23 CDT 2013
#1406: Commit r5034 to the flesh breaks many external libraries
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: knarf@…
Type: defect | Status: review
Priority: critical | Milestone: ET_2013_11
Component: SimFactory | Version: development version
Resolution: | Keywords:
-------------------------+--------------------------------------------------
Comment (by knarf):
We probably shouldn't use CPPFLAGS to pass to the C or C++ compiler, but
the corresponding CFLAGS ect. Is there a reason we shouldn't do that? The
CFLAGS for instance shouldn't (do they?) contain the actual action (like
compiling). Shouldn't they work just as well, or better?
Also, can I assume your last comment means 'reviewed ok'?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1406#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list