[ET Trac] [Einstein Toolkit] #1236: ReflectionSYmmetry does not handle vector groups of vectors correctly

[Einstein Toolkit]

#1236: ReflectionSYmmetry does not handle vector groups of vectors correctly
---------------------+------------------------------------------------------
  Reporter:  rhaas   |       Owner:                                                           
      Type:  defect  |      Status:  reopened                                                 
  Priority:  minor   |   Milestone:  ET_2013_11                                               
 Component:  Cactus  |     Version:                                                           
Resolution:          |    Keywords:  RelfectionSymmetry RotatingSymmetry180 RotatingSymmetry90
---------------------+------------------------------------------------------
Changes (by rhaas):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Apparently I was not being all too careful when testing the statement that
 {{{CCTK_VarIndex("velx[0]") + 1 == CCTK_VarIndex("vely[0]")}}} for a group
 of vectors. This is actually incorrect and the patch that was committed
 thus is also incorrect (though simple vector groups vel[i] or
 (betax,betay,betaz) are not affected).

 The attached patch uses the correct algorithm, which uses that the
 variables are not laid out as
 {{{
 fnux[0], fnuy[0], fnuz[0], fnux[1], ...
 }}}
 but instead as
 {{{
 fnux[0], fnux[1], fnux[2], fnuz[0], ...
 }}}

 The essentially replaces "vi % numcomps" by "vi / vectorlength" with
 special case for vel[i] type groups that are vectors of scalars.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1236#comment:12>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit