[ET Trac] [Einstein Toolkit] #1276: Intel 2013.1.117 mis-compiles NewRad

[Einstein Toolkit]

#1276: Intel 2013.1.117 mis-compiles NewRad
-----------------------------------+----------------------------------------
 Reporter:  rhaas                  |       Owner:     
     Type:  defect                 |      Status:  new
 Priority:  minor                  |   Milestone:     
Component:  EinsteinToolkit thorn  |     Version:     
 Keywords:  NewRad                 |  
-----------------------------------+----------------------------------------
 Intels compiler fails (with -O2) to push values for bmin onto the stack in
 lines 316 of newrad.cc and line 126 of extrap.cc. Adding printf's for bmin
 perturbs the bug out of existence, but adding a printf of the address of
 bmax and reveals that at the time extrap_kernel is call the integer just
 before this address is still the initialization value of bmin[2] and not
 the correct value.

 The attached patch disables optimization for the two driver functions
 affected (but not the actual kernel).

 The patch is specific (via an #if) for this particular compiler and
 version. What is the best way of handling this? Target any intel version
 starting from the known failing one until we know of known good one? Or
 starting from an older known good one (that would be intel 11 in my case).

 Hopefully no similar bug is triggered by Carpet's use of the same idiom.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1276>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit