[ET Trac] [Einstein Toolkit] #1277: GRHydro updates

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Mar 4 09:28:50 CST 2013


#1277: GRHydro updates
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:         
      Type:  enhancement            |      Status:  review 
  Priority:  minor                  |   Milestone:         
 Component:  EinsteinToolkit thorn  |     Version:         
Resolution:                         |    Keywords:  GRHydro
------------------------------------+---------------------------------------

Comment (by knarf):

 0003 is fine. 0002 contains a line in the makefile with
 "#GRHydro_TestSync.cc". This doesn't seem to be necessary - some leftover?

 Some of these patches contain tabs. Please convert to spaces because in
 general GRHydro doesn't use tabs for intendation and mixing is looking
 ugly (and using tabs for something else is a bad idea).

 0002: GRHydro_MP5Reconstruct_drv() contains calls to CCTK_EQUALS for each
 1D line of calling reconstruction. The result of this string comparison
 should probably be saved first and reused later. However, this is also
 currently the case for the (W)ENO reconstructions, so it would make sense
 to do this there as well.

 Didn't "look" at 0004 and 0005, but I assume these testsuites are ok.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1277#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list