[ET Trac] [Einstein Toolkit] #591: Add harmonic shift to McLachlan

[Einstein Toolkit]

#591: Add harmonic shift to McLachlan
------------------------------------+---------------------------------------
  Reporter:  hinder                 |       Owner:            
      Type:  defect                 |      Status:  reopened  
  Priority:  major                  |   Milestone:            
 Component:  EinsteinToolkit thorn  |     Version:  ET_2012_11
Resolution:                         |    Keywords:  McLachlan 
------------------------------------+---------------------------------------
Changes (by bernard.j.kelly@…):

  * priority:  minor => major
  * status:  closed => reopened
  * version:  => ET_2012_11
  * resolution:  fixed =>
  * type:  enhancement => defect


Comment:

 The harmonicShift currently in the repository assumes that the code is in
 the "conformalMethod==CMW" branch (that is, using W == exp(-2 phi) in
 place of the original BSSN " phi"), but does not test for it.

 The attached patch (relative to the ET_2012_11 release) corrects this
 assumption, making a BSSN-phi version available also.

 The patch also splits off a particular term, Ddetgt[la] == gtu[uk,ul]
 PD[gt[lk,ll],la], that should vanish when det(gtil) == 1. By default, it
 is still calculated explicitly and inserted into the harmonicShift RHS, to
 pass the test suite.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/591#comment:8>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit