[ET Trac] [Einstein Toolkit] #1276: Intel 2013.1.117 mis-compiles NewRad

Einstein Toolkit trac-noreply at einsteintoolkit.org
Fri May 3 15:37:42 CDT 2013


#1276: Intel 2013.1.117 mis-compiles NewRad
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:                     
      Type:  defect                 |      Status:  review             
  Priority:  critical               |   Milestone:  ET_2013_05         
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:  NewRad             
------------------------------------+---------------------------------------

Comment (by eschnett):

 This patch doesn't disable restrict. The default case, where "restrict"
 remains undefined, leaves restrict enabled (since it remains "restrict").
 I recommend changing only HAVE_CCTK_C_RESTRICT and CCTK_C_RESTRICT, and
 keeping the logic that redefines "restrict". Alternatively, add the Intel
 #ifdef afterwards, and just overwrite HAVE_CCTK_C_RESTRICT,
 CCTK_C_RESTRICT, and restrict.

 #if BORKEN_INTEL
 #  undef HAVE_CCTK_C_RESTRICT
 #  undef CCTK_C_RESTRICT
 #  undef restrict
 #  define CCTK_C_RESTRICT
 #  define restrict
 #endif

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1276#comment:24>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list