[ET Trac] [Einstein Toolkit] #1261: Suspicious logic in NewRad thorn

[Einstein Toolkit]

#1261: Suspicious logic in NewRad thorn
------------------------------------------+---------------------------------
  Reporter:  wolfgang.kastaun@…           |       Owner:            
      Type:  defect                       |      Status:  review    
  Priority:  critical                     |   Milestone:  ET_2013_05
 Component:  EinsteinToolkit thorn        |     Version:  ET_2012_11
Resolution:                               |    Keywords:  backport  
------------------------------------------+---------------------------------

Comment (by knarf):

 Patch 'NewRad' didn't pass the testsuite, which I have to assume is
 correct, according to Ian. The new patch 'NewRad2' does correct the
 inconsistency in the code and removes the unused variable; and it passes
 the testsuite. It also renames 'all_physbnd_or_ghostbnd' to
 'all_not_ipbnd', as that is what is actually calculated. The respective
 NewRad kernels are, using the new variable name, only called

   if (have_bnd and any_physbnd and all_not_ipbnd)

 Please review.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1261#comment:11>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit