[ET Trac] [Einstein Toolkit] #1478: Prim2ConCells using general Coordinates

[Einstein Toolkit]

#1478: Prim2ConCells using general Coordinates
--------------------------------+-------------------------------------------
  Reporter:  tl806@…            |       Owner:                     
      Type:  defect             |      Status:  new                
  Priority:  minor              |   Milestone:                     
 Component:  Other              |     Version:  development version
Resolution:                     |    Keywords:                     
--------------------------------+-------------------------------------------

Comment (by rhaas):

 Very good. Much relieved to hear that we did not have a bug in the code
 after all.

 If you go to the top of the file (GRHydro_Prim2ConM.F90) then there area
 set of C preprocessor macros that define velx(i,j,k) as vup(i,j,k,1) etc.
 If you are familiar with the Whisky code then there is a change in
 notation in GRHydro since HydroBase (which provides the primitives) does
 not use velx, vely and velz but rather just vel(i,j,k,D) where D is 1,2,3
 for x,y,z. Since some authors like velx better we often have defines for
 velx at the top of the files and use those instead. Since the define map
 velx to vup, I believe that indeed the current code is correct (though
 maybe confusing).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1478#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit