[ET Trac] [Einstein Toolkit] #1481: Hidden hard-coded limits on max_l_modes and max_vars in Multipole

[Einstein Toolkit]

#1481: Hidden hard-coded limits on max_l_modes and max_vars in Multipole
--------------------------------------+-------------------------------------
 Reporter:  bernard.j.kelly@…         |       Owner:            
     Type:  defect                    |      Status:  new       
 Priority:  major                     |   Milestone:  ET_2013_11
Component:  EinsteinToolkit thorn     |     Version:  ET_2013_05
 Keywords:  Multipole                 |  
--------------------------------------+-------------------------------------
 The EinsteinAnalysis/Multipole thorn has hard-coded limits (in
 src/multipole.cc) on the number of grid functions that can be decomposed
 (max_vars) and how high in polar quantum number this decomposition can go
 (max_l_modes). However, these are not reflected in the thorn's param.ccl.

 In fact, param.ccl contains a parameter "l_max", allowing it to be *any*
 positive value, and doesn't test this against max_l_modes until execution
 of this source. Wouldn't it make more sense to impose max_l_modes
 immediately at PARAMCHECK?

 To make the actual limit on interpolated functions explicit, a number of
 desired interpolants could be set in param.ccl (like "n_variables") ---
 limited if necessary to a hard-coded number that appears as a limit in the
 range. If the user tries to set n_variables too high, it gets caught at
 PARAMCHECK; if (s)he accidentally includes too many entries in the
 "variables" parameter, the extra ones would just be silently ignored.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1481>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit