[ET Trac] [Einstein Toolkit] #1448: move PARAMCHECK before WRAGH

[Einstein Toolkit]

#1448: move PARAMCHECK before WRAGH
---------------------+------------------------------------------------------
  Reporter:  rhaas   |       Owner:                     
      Type:  defect  |      Status:  new                
  Priority:  minor   |   Milestone:                     
 Component:  Cactus  |     Version:  development version
Resolution:          |    Keywords:                     
---------------------+------------------------------------------------------

Comment (by rhaas):

 ok. This will require some rewriting of code inside of Carpet I think.
 Right now the docs for the time bins ion page D28 of the user guide) say:
 {{{
 CCTK WRAGH This timebin is executed when all parameters are known, but
 before the driver
           thorn constructs the grid. It should only be used to set up
 information that is
          needed by the driver.
 CCTK PARAMCHECK This timebin is for thorns to check the validity of
 parameter combinations. This
                bin is also executed before the grid hierarchy is made, so
 that routines scheduled
               here only have access to the global grid size and the
 parameters.
 }}}
 so no one in PARAMCHECK may expect access to grid functions and
 technically grid arrays and grid scalars are also not mentioned. Checking
 the various schedule.ccl there are routines scheduled in WRAGH (eg
 CarpetRegrid2_Initialise) that access grid scalars. So we will need to
 turn on grid arrays and grid scalars before WRAGH (and hope that those are
 "small" which I have at least one thorn for which this is not true since
 it allocates 3d distributed grid arrays). Probably best committed after
 the release.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1448#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit