[ET Trac] [Einstein Toolkit] #1066: Implement IMEX integrators in MoL

[Einstein Toolkit]

#1066: Implement IMEX integrators in MoL
------------------------------------+---------------------------------------
  Reporter:  eschnett               |       Owner:          
      Type:  enhancement            |      Status:  reopened
  Priority:  major                  |   Milestone:          
 Component:  EinsteinToolkit thorn  |     Version:          
Resolution:                         |    Keywords:          
------------------------------------+---------------------------------------
Changes (by rhaas):

  * status:  review => reopened


Comment:

 I had a look at the patch and have some comments (from important to
 nitpicking):

 * it uses steerable parameters RKevalRHSex, RKevalRHSim (lines 80 and 81)
 and RKstiff and RKtime to tell the client thorn which RHS to evalute.
 Instead it should use grid scalars.
 * implicit array variables seem broken

 * the error message in 169 and 235 seems wrong since "does not correspond
 to a GF" usually means varindex=-1 whereas here the error seems to be "has
 no storage"
 * no test case (so far)
 * no documentation

 * lines 534--537 mention an ODE_Method "RKIMEX" which does not exist and
 should be removed
 * commented out code in line 406
 * CCTK_GroupName in line 634 returns a string that needs to be free()'d
 (does not matter here since we abort anyway)
 * line 655 is leftover debug code
 * uses CCTK_VWarn(0, ...) instead of CCTK_VError
 * uses CCTK_VWarn(1, ...) instead of CCTK_VWarn(CCTK_WARN_ALERT, ...)

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1066#comment:7>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit