[ET Trac] [Einstein Toolkit] #1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Apr 1 16:54:47 CDT 2014


#1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code
with no comment
-----------------------------------+----------------------------------------
 Reporter:  rhaas                  |       Owner:                     
     Type:  defect                 |      Status:  new                
 Priority:  optional               |   Milestone:                     
Component:  EinsteinToolkit thorn  |     Version:  development version
 Keywords:  QuasiLocalMeasures     |  
-----------------------------------+----------------------------------------
 qlm_killing_normalise in qlm_killing_normalise.F90 triggers an unused
 variable warning for iii. Looking at the file, the code that would use the
 variable is inside of an {{{#if 0}}} but there is no indication (neither
 in the commit message nor in the code) what the difference between the if
 and the else branch is.

 I'd like to either replace the if0 by an if USE_THIS_MEHTOD (and use the
 same preprocessor constant for the variable declaration) or (even better)
 remove the whole if0 branch.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1570>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list