[ET Trac] [Einstein Toolkit] #1589: suspicious code for operator+ in bboxset2
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Thu Apr 24 03:37:39 CDT 2014
#1589: suspicious code for operator+ in bboxset2
---------------------+------------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: reviewed_ok
Priority: major | Milestone:
Component: Carpet | Version: development version
Resolution: | Keywords: Carpet
---------------------+------------------------------------------------------
Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Where is the {{{+}}} operator that combines different box.exteriors? Is
this the one changed in patch 0003?
Operator {{{^}}} calculates the symmetric set difference. Due to the
internal representation used by bboxset2, which is based on symmetric set
differences, this operator is especially efficient. I believe the current
code is correct, and the patch only makes things less efficient. Please do
not apply it.
Patch 0003 looks correct. I do not know why the fine grid boundaries
should be disjoint. Please apply it.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1589#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list