[ET Trac] [Einstein Toolkit] #1600: SphericalHarmonicRecon regression_test fails on many machines

[Einstein Toolkit]

#1600: SphericalHarmonicRecon regression_test fails on many machines
------------------------------------+---------------------------------------
  Reporter:  hinder                 |       Owner:                     
      Type:  defect                 |      Status:  new                
  Priority:  major                  |   Milestone:  ET_2014_05         
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:                     
------------------------------------+---------------------------------------

Comment (by rhaas):

 the routine setup_circle_masks in
 PITTNullCode/NullInterp/src/NullInterp_MaskInit.F90 contains in line
 101 code that reads:

 {{{
 98     ! check that there is enough room left
 99     ! for guard  points near the patch boundaries
 100
 101     if (((lbnd(1).eq.0).and.any(EG_mask(1:N_ang_stencil_size,:).ne.0))
 .or. &
 102
 ((ubnd(1).eq.gsh(1)-1).and.any(guard_mask(lsh(1)-N_ang_stencil_size+1:,:).ne.0))
 .or. &
 103
 ((lbnd(2).eq.0).and.any(guard_mask(:,1:N_ang_stencil_size).ne.0)) .or. &
 104
 ((ubnd(2).eq.gsh(2)-1).and.any(guard_mask(:,lsh(2)-N_ang_stencil_size+1:).ne.0)))
 &
 105          call CCTK_WARN(0, "mask setup error");
 106
 107     ! mark guard points 108
 }}}

 The first condition
 "((lbnd(1).eq.0).and.any(EG_mask(1:N_ang_stencil_size,:).ne.0))" seems
 incorrect to me since it (alone) tests EG_mask rather than guard_mask
 as the others do.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1600#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit