[ET Trac] [Einstein Toolkit] #1557: include thorn TestMoL in ET

Einstein Toolkit trac-noreply at einsteintoolkit.org
Fri Mar 14 10:55:05 CDT 2014


#1557: include thorn TestMoL in ET
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:                     
      Type:  enhancement            |      Status:  review             
  Priority:  optional               |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:  MoL                
------------------------------------+---------------------------------------

Comment (by rhaas):

 * Fixed typos in Register.c
 * removed unnecessary includes
 * removed cctk_Functions.h. It is automatically included by cctk_core.h
 and provides the aliased function prototypes. Is there a reason why this
 not also done for Fortran?
 * added assert's on the return values. They will never trigger since MoL
 itself contains level 0 warnings whenever it would not return 0 (this is
 documented in MoL's documentation.tex).

 Frank: would you mind creating a repository for the thorn in CactusTests?
 Alternatively, we can wait until the gid transition and add it at that
 point.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1557#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list