#1604: Uninitialised data in tests using PUGH
------------------------------------+---------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2014_05
Component: EinsteinToolkit thorn | Version: development version
Resolution: | Keywords:
------------------------------------+---------------------------------------
Comment (by diener):
The gaussian test from wavetoy with PUGH poisoning turned on fails due to
the application of the radiative boundary condition to the initial data.
The radiative boundary condition uses data from the previous timelevel (if
available, which it is in this case) to set the boundary. As IDWaveMoL
only initializes the current timelevel, the outer boundary gets filled
with NaN's when PUGH poisoning is turned on.
The simple fix is to initialize the data on the previous timelevel to
zero. This makes the test pass for me and seem to indicate that the
compiler used to originally generate the test automatically initialized
arrays to zero.
However, as the initial data is setup analytically at the boundary, I
think the more correct way to fix this is to not apply the boundary
conditions initially. This can be achieved by setting the MoL parameter
set_ID_boundaries to no. In this case the test has to be regenerated as
the starting point now is the correct initial data everywhere. Which of
these options do people prefer?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1604#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit