[ET Trac] [Einstein Toolkit] #1377: Cacus could/should provide M_PI

[Einstein Toolkit]

#1377: Cacus could/should provide M_PI
--------------------------+-------------------------------------------------
  Reporter:  sbrandt      |       Owner:                     
      Type:  enhancement  |      Status:  new                
  Priority:  minor        |   Milestone:                     
 Component:  Cactus       |     Version:  development version
Resolution:               |    Keywords:  GRHydro M_PI       
--------------------------+-------------------------------------------------

Comment (by eschnett):

 Defining M_PI would lead to a failure in this code:
 {{{
 #include <cctk_Constants.h>   // defines M_PI
 #include <math.h>   // error -- M_PI is already defined
 }}}

 The C standard does not allow defining constants that start with "M_";
 thus in this example, Cactus is at fault for violating the C standard.

 Can we close this as "wontfix"?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1377#comment:10>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit