[ET Trac] [Einstein Toolkit] #1377: Cacus could/should provide M_PI

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon May 19 14:07:30 CDT 2014


#1377: Cacus could/should provide M_PI
--------------------------+-------------------------------------------------
  Reporter:  sbrandt      |       Owner:                     
      Type:  enhancement  |      Status:  new                
  Priority:  minor        |   Milestone:                     
 Component:  Cactus       |     Version:  development version
Resolution:               |    Keywords:  GRHydro M_PI       
--------------------------+-------------------------------------------------

Comment (by rhaas):

 If we want to provide M_PI (as per comment:12), we can try and test for
 M_PI in autoconf, then if M_PI is defined define HAVE_M_PI and only define
 M_PI in cctk_Constants.h if HAVE_M_PI is not defined. This is the same
 logic we use to re-define the reserved word "restrict" (and possibly
 "inline", though I don't quite remember at this point) and may work fine
 in this case as well.

 Or we can state that Cactus requires POSIX and current POSIX versions
 don't require M_PI. This may lead to users defining there own M_PI, or use
 C++ or GSL which do define M_PI. A uniform, Cactus wide solution seems
 preferable.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1377#comment:11>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list