[ET Trac] [Einstein Toolkit] #1825: CCTK_ImpFromVarI sometimes returns the thorn name

[Einstein Toolkit]

#1825: CCTK_ImpFromVarI sometimes returns the thorn name
----------------------+-----------------------------------------------------
  Reporter:  sbrandt  |       Owner:                     
      Type:  defect   |      Status:  new                
  Priority:  minor    |   Milestone:                     
 Component:  Other    |     Version:  development version
Resolution:           |    Keywords:                     
----------------------+-----------------------------------------------------

Comment (by knarf):

 In the code I see:
 {{{
   if (groupscope == CCTK_PUBLIC || groupscope == CCTK_PROTECTED)
   {
     group = CCTKi_SetupGroup (imp, gname,
                               n_basevars * vectorlength, vectorlength);
   }
   else if (groupscope == CCTK_PRIVATE)
   {
     group = CCTKi_SetupGroup (thorn, gname,
                               n_basevars * vectorlength, vectorlength);
   }
 }}}
 In short: for private variable groups, the implementation name is set to
 be the thorn name. This looks odd, but seems to be intentional.

 It can also be found in the manual:
 The group name should be the given in its fully qualified form, that is
 \code{<implementation>::<group>} for a public or protected group, and
 \code{<thornname>::<group>} for a private group.

 It probably should be mentioned in the docu for CCTK_ImpFromVarI as well.
 Anyone disagrees?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1825#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit