[ET Trac] [Einstein Toolkit] #1862: Patch: make Refluxing infrastructure independent of GRHydro

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Apr 7 12:26:45 CDT 2016


#1862: Patch: make Refluxing infrastructure independent of GRHydro
------------------------------------+---------------------------------------
  Reporter:  dradice@…              |       Owner:                     
      Type:  enhancement            |      Status:  reviewed_ok        
  Priority:  major                  |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:                     
------------------------------------+---------------------------------------
Changes (by rhaas):

  * status:  review => reviewed_ok


Comment:

 I added minor comments on grhydro_refluxing to
 https://bitbucket.org/dradice/grhydro_refluxing/commits/8f972d5dd86c72cb9fe6ac473dc3640d8be152d4
 . Nothing big, mostly just some unused routines (are yout ''supposed'' to
 be unused ?) and a request to not use sprintf and to document a purpose
 for the thorn. Otherwise grhydro_refluxing is fine with me.

 I added a single minor comment to refluxing here
 https://bitbucket.org/dradice/refluxing/commits/faad5bc55245e102022a958dde6918f30d2d3b43
 .

 Note that the new refluxing removes various experimental code that never
 quite worked as desired. This is with approval of the author (Erik) and
 user (Christian Reisswig) for whom these were added (as far as I know).
 While this technically removes features from an ET thorn, the features
 were highly experimental.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1862#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list